You’re right, I was referring to Camp David, and the deal sounds pretty good conpared to today’s situation
It's better than today's situation, but the thing is that nobody could've predicted the situation would get this bad. Also, the thing about accepting a two-state solution is that it's a one-time thing. All proposals so far included considering the conflict ended, so when you accept a Palestinian state with no East Jerusalem, no territorial contiguity (the offer would have it divided into four parts connected by Israeli territory that could be closed off in cases of emergency) and no control over its own airspace or water sources, you're stuck with these things forever.
the establishment of the Palestinian capital in east Jerusalem, in which some Arab neighborhoods would become sovereign Palestinian territory and others would enjoy “functional autonomy”
I have to question the accuracy of this, given that the Israeli PM stated that he wasn't willing to grant Palestinians anything more than symbolic sovereignty over East Jerusalem at the start of the negotiations, and in fact that was one of the main contention points.