I tend to draw the line around the 500 VMs mark and whether you use hyper-converged hardware. Above 500 VMs you are likely to be using dedicated storage, where XCP-ng will scale more easily.
Proxmox makes hyper-converged management simpler than XCP-ng and can handle more complex networking setups out of the box.
But there is a pretty large overlap between their capabilities.