I FIXED AMD's Preferred Core Linux patch to FINALLY work for HIGHER BOOST and PERFORMANCE !

demonsword , 10 months ago

TL;DW?

Olissipo , 10 months ago

Apparently there’s a bug in an AMD’s driver. It was supposed to assign processes based on each core’s self reported performance, but because of the bug it was random.

This “self reported performance” is based on evaluation done to the cores in the fab process, by AMD. Meaning, due to imperfections some cores are a bit better than others.

NoXPhasma , 10 months ago

It’s not just random, it simply does not even work. Because they set this:

<span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">/*Preferred Core featue is supported*/
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">static bool prefcore = true;
</span>

And later in the code they do the if condition wrong:

<span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">	if (prefcore)
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">	else
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
</span>

if should look like this:

<span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">	if (prefcore)
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">	else
</span><span style="background-color:#eaffea;font-weight:bold;color:#55a532;">+</span><span style="background-color:#eaffea;color:#323232;">		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
</span>

There is probably even more wrong, looking at the code quality, but this at least makes the preferred core work.

Olissipo , 10 months ago

I don’t know if we’re discussing semantics. A performance score is attributed, and before the fix their scores were all 166. It doesn’t work, as you said. So the consequence is the preferred core being “random”, isn’t it?

NoXPhasma , 10 months ago

I don’t know if it’s random, the CPU scheduler still decides what thread to use. It will have its own semantics, but I don’t know on what those are based.

NoXPhasma , 10 months ago

AMD patches for preferred core (prefer those cores which can clock higher) are a mess and ended up not working because of a wrong if condition. Showing that no one at AMD even tested it before submitting. The programmer in the video complains about AMDs developers being incompetent and shows how it’s fixed.

demonsword , 10 months ago

thanks :)

Gurfaild , 10 months ago

I FIXED my CAPSLOCK KEY to FINALLY enable CRUISE CONTROL for COOL

tal , 10 months ago

If the Daily Mail's editors do it, it must be a good idea!

Dubious_Fart , 10 months ago

I can not tell you how many videos and channels I avoid because of that shit.

also ones that have dumb ass thumbnails that do nothing to hint about the content.

featured , 10 months ago

Agreed, have you tried Dearrow? It’s from the person who created SponsorBlock and is a crowdsourced way to get rid of the clickbait

Dubious_Fart , 10 months ago

I’d rather just not give the jackasses the attention, than go out of my way to use an app to hide their jackassery

GitProphet , 10 months ago

agreed

dinckelman , 10 months ago

I love this addon. It’s made my YouTube experience significantly better

LoafyLemon , 10 months ago

BETTER VISIBLE, VISIBLY BETTER

BautAufWasEuchAufbaut , 10 months ago

Is this just because of the title, or is the video’s content contentless? /gen

yote_zip , 10 months ago (edited 10 months ago)

“This is on version 4 and approved by many people and it doesn’t even work. How was this tested?” types furiously in comic sans

This video is killing me. Very entertaining to share their frustration.

Edit: “When we reach 25k subscribers I will debug the Linux scheduler”

poVoq , 10 months ago

AMD’s software has always been in a very sorry state. Only after non-inhouse developers created an alternative GPU driver from scratch for Linux it became feasible to use.

PipedLinkBot , 10 months ago

Here is an alternative Piped link(s): piped.video/watch?v=PUNhqliGgvc

Piped is a privacy-respecting open-source alternative frontend to YouTube.

I’m open-source, check me out at GitHub.

trclst OP , 10 months ago

I am not the creator of the video but amazed what it all makes it into the stable branch.