So, if I just wait for the argument to cool off, then start replying, over and over, to anyone but the person I am directly disagreeing with, but still in the same thread, until the automatic votes accumulate to my favor, I will always be right?
There’s a lint rule that looks for @nocommit in all modified files. It shows a lint error in dev and in our code review / build system, and commits that contain @nocommit anywhere are completely blocked from being merged.
(the code in the lint rule does something like “@no”+“commit” to avoid triggering itself)
Neat idea. This could be refined by adding a git hook that runs (rip)grep on the entire codebase and fails if anything is found upon commit may accomplish a similar result and stop the code from being committed entirely. Requires a bit more setup work on de developers end, though.
Would a git hook block you from committing it locally, or would it just run on the server side?
I’m not sure how our one at work is implemented, but we can actually commit @nocommit files in our local repo, and push them into the code review system. We just can’t merge any changes that contain it.
It’s used for common workflows like creating new database entities. During development, the ORM system creates a dev database on a test DB cluster and automatically points the code to it with a @nocommit comment above it. When the code is approved, the new schema is pushed to prod and the code is updated to point to the real DB.
Also, the codebase is way too large for something like ripgrep to search the whole codebase in a reasonable time, which is why it only searches the commit diffs themselves.
At my workplace, we use the string @nocommit to designate code that shouldn’t be checked in
That approach seems useful but it wouldn’t have prevented the PyPI incident OP links to: the access token was temporarily entered in a .py python source file, but it was not committed to git. The leak was via https://docs.python.org/3/tutorial/modules.html#compiled-python-files which made it into a published docker build.
Not just for credentials, there are many times where I change a setting or whatever and just put “//TODO: remember to set it back to ‘…’ before commiting”. I forget to change it back 99% of the time.
PRs? Isn’t the point of @nocommit that something does not get committed, and therefore no credentials are stored in the git repository? Even if the PR does not get merged, the file is still stored as a hit object and can be restored.
I’m not canadian, so I don’t have a lot of experience with robertson. But from the limited experience that I do have, I would rate it 10/10.
What would you recommend for smaller screws (e.g. for electronics)? As far as I know, there aren’t smaller sizes of robertson like there are with torx?
I’ve driven tens of thousands of pozidrive 2/3 screws into timber with an impact driver. For whatever reason my experience is the diametric opposite of yours. Big up the Pozidrive massive.
It’s probably because of the impact driver. The bit seats back into the bottom of the slot between every impact. This doesn’t happen with normal drivers.
LOL sure, good one… Only time that square abomination is the answer is if the question is “what do you get if you put a toddler in charge of designing a poor knockoff unbrako head?”
lemmy.world
Oldest