Because with almost billion iPhone users you could still have several million sales even if your entire customer base for your new phone are upgrading from old phones?
Or in short; it’s profitable enough to keep doing that.
Though we’ve clearly gotten to a point where twice-yearly releases aren’t worth it.