To be fair, the PiHole is just doing a firewall function: DNS filtering. If you have a fully featured router/firewall like PFsense, you can do everything a PiHole does using that. So I see how one could argue that a PiHole might benefit from dual NICs, but in practice, for home users, I agree that it’s not necessary.