I largely agree with your analysis here. My point was that the way the economy is portrayed is such that we don’t get to see much of how it actually works, meaning that a lot of our understanding is speculation based on a handful of lines.
Meanwhile, they’re still participating in the aesthetics of commerce within the Federation, and literal commerce beyond its borders. The idea that there’s a currency used for trade outside the Federation, but citizens get everything for free within it, is a popular interpretation but it’s never actually explicitly stated within the text outside vague mentions of a “Federation credit”. It’s personally my favorite interpretation, but I think everything’s vague and in the background enough that I can see how people can walk away with different interpretations. Just look at that Ex Astris Scientia article; I even disagree with where some of the evidence should fall on whether it’s pro- or contra- money.
The wildcard here is that we see Federation worlds that seem to still use money, namely the Bolians who are members of the Federation, but the Bank of Bolias is a major financial institution.
The interesting thing to me is that people often assert that replicators are the reason that money doesn’t exist in the Federation, but that’s simply not the case; it’s established in VOY that money “went the way of the dinosaur” in the late 22nd century, prior to the invention of the replicator over a century later. Neither replicators nor money existed in Kirk’s era. It seems that replicators are not essential to eliminating money in the Trek universe, although I’m sure they’re a boon to the standards of living.