Certainly it is illegal to distribute Vanced because it’s a modified version of Youtube official app, which is copyrighted.
Re-vanced may have found a workaround so that users modify the app themselves, but Google may claim DMCA’s anti-circunvention rule is being breached, and sue the relevant parties if they wanted to.