It likely will stop official OTA updates to your device.
I do not recommend anything other than the newer Magisk methods, and if your device kernel is over 5.10, KernelSU.
The idea is simple; you need to patch the userland for Magisk, and the kernel for KernelSU. Device specific instructions are small nuances - did you get your bootloader unlocked?