I upgraded mine to an S23 last March. Main reason was because the battery could no longer last through the day. Otherwise I was perfectly content with it.
I like to buy the phone outright rather than get one on contract but the flagship phones are just so expensive nowadays. My S8’s battery is getting steadily worse so I’ll probably upgrade when I can no longer ignore it. At the minute I just don’t feel like I can justify such a massive expense for something that will essentially just be more of the same only a bit bigger and a bit faster. Maybe I’ll go for a Pixel instead.
I didn’t want to risk damaging it as I needed it for work. It was much safer to upgrade and then try to experiment with the S8. There’s also the fact they stopped giving the S8 security updates, so that’s a big concern, too.
After having used the S23, I couldn’t go back anymore. It’s significantly better in most ways. I always keep battery saver mode on which stops charging at 85%. With how much I use my phone, the charge rarely goes below 40%.
I did try Sony’s 5 IV before the S23. I really wanted to love it, but as a photographer, there were some fatal flaws with the camera apps. It had so much going for it, too: 5000 mAh battery (S23’s is 3900 mAh, S8’s is 3000), audio jack, microSD card slot, removable SIM card, 4k OLED screen, a dedicated shutter button for the cameras, and can record 4k 120Hz video, if only for a literal minute.
If you don’t plan on using your phone for more professional photos (even though that’s kind of what they market it for…), I would recommend checking out their lineup.
Edit: Oh, and Sony only officially supports their phones for two years. Compare that with Samsung’s 5. So that’s another thing to consider.
IIRC people with older devices have found that replacing their battery does not significantly help, becathe replacement battery was manufactured at roughly the same time as the device it goes into, and has degraded over time even without use. This is anecdotal of course, but seems reasonable to me.
Some short browsing appears to indicate that batteries can last for years of stored properly, but how does one verify if the replacement battery in their phone was really stored appropriately?